[tor-bugs] #31918 [Applications/Tor Browser]: Rebase and squash mobile and desktop patches

[Tor Bug Tracker & Wiki]

#31918: Rebase and squash mobile and desktop patches
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  acat
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.5, ReleaseTrainMigration,      |  Actual Points:
  TorBrowserTeam202005R                          |
Parent ID:  #33656                               |         Points:  1
 Reviewer:  sysrqb, gk                           |        Sponsor:
                                                 |  Sponsor58-must
-------------------------------------------------+-------------------------
Changes (by acat):

 * keywords:  tbb-9.5, ReleaseTrainMigration, TorBrowserTeam202004 =>
     tbb-9.5, ReleaseTrainMigration, TorBrowserTeam202005R
 * status:  needs_revision => needs_review


Comment:

 Thanks for the review: here is the revised branch:
 https://github.com/acatarineu/tor-browser/commits/31918+1
 (4f94bc827bb8045b3c6504e8c65c5629d76c2313).

 I did what you suggested, and also squashed `Bug 29859: Disable HLS
 support for now`, with mozconfs, as I thought it might belong there.

 > 5) Squash the old.configure changes into TB3: Tor Browser's official
 .mozconfigs and just start using --enable-tor-browser-data-outside-app-dir
 in from that commit on? (Essentially similar to my TOR_BROWSER_VERSION
 idea from above)
 Should we do this also with the other two flags that we define?
 (--disable-tor-launcher, --disable-tor-browser-update). I mean, define
 them in the mozconfig commit, and use them later.

 I'll use the `31918+1` branch for next #33533 rebase, as essentially the
 `33533+4..31918+1` did not change. I can revise that later if necessary
 because of `revision_needed` here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31918#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online