[tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6

[Tor Bug Tracker & Wiki]

#33679: Make sure every address function that takes for_listening supports IPv6
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop312, ipv6, outreachy-ipv6,       |  Actual Points:
  network-team-roadmap-2020Q1                    |
Parent ID:  #33049                               |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
                                                 |  Sponsor55-must
-------------------------------------------------+-------------------------
Changes (by MrSquanchee):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:15 teor]:


 > The test has an invalid IPv6 address,

 Thanks teor,

 The PR is all green now :)
 You can review it [https://github.com/torproject/tor/pull/1831 here].

 Replying to [comment:15 teor]:
 > It looks like the data returned is different on Windows vs macOS/Linux,
 when tor_inet_pton() gets some invalid addresses.
 > I opened #33768 to fix this bug - the functions should behave the same
 across all platforms.

 Yeah !! sometimes stupidity proves to be useful. haha.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33679#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online