[tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6

[Tor Bug Tracker & Wiki]

#33679: Make sure every address function that takes for_listening supports IPv6
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop312, ipv6, outreachy-ipv6,       |  Actual Points:
  network-team-roadmap-2020Q1                    |
Parent ID:  #33049                               |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
                                                 |  Sponsor55-must
-------------------------------------------------+-------------------------

Comment (by MrSquanchee):

 Replying to [comment:13 asn]:
 > For what it's worth appveyor seems broken with:
 > {{{
 > addr/address_validity:
 >   FAIL ../src/test/test_addr.c:1730: assert(tor_addr_is_valid(test_addr,
 0) OP_EQ 1): 0 vs 1
 >   [address_validity FAILED]
 > }}}
 >
 > teor, we will let you figure if you want to move this to needs_revision!

 Hii asn,

     The above line of code works fine with linux.

 Also the test case is reasonable in the context.

 I don't really have a clue why it is failing in appveyor and

 passing in travis ci. Could you suggest something ??

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33679#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online