[tor-bugs] #33414 [Core Tor/Tor]: Split router.c, and disable it (mostly) when building without relay support.

[Tor Bug Tracker & Wiki]

#33414: Split router.c, and disable it (mostly) when building without relay
support.
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-design, network-team-roadmap-    |  Actual Points:  0.5
  2020Q1, 043-deferred                           |
Parent ID:  #31851                               |         Points:  0.5
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've answered the comment about the missing lock: that lock is only used
 to protect onion keys, which clients don't have.

 I've also fixed the typo and rebased to master.  I checked the conflicting
 diff in question (07ab22bfd3ce43a7c3f8a5e7dd8608ceb1de18b6) with --color-
 moved to make sure I didn't mess up any other code, but an extra look-see
 wouldn't hurt.

 I opened #33739 for moving the dirauth-only keys to the dirauth module.

 The new branch is `extract_router_rebased` with PR at
 https://github.com/torproject/tor/pull/1839

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33414#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online