[tor-bugs] #30905 [Core Tor/sbws]: Maybe monitoring values in the state file should be reset when sbws is restarted

[Tor Bug Tracker & Wiki]

#30905: Maybe monitoring values in the state file should be reset when sbws is
restarted
---------------------------+-----------------------------------
 Reporter:  juga           |          Owner:  juga
     Type:  defect         |         Status:  needs_review
 Priority:  Medium         |      Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws  |        Version:  sbws: 1.1.0
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #30719         |         Points:  1
 Reviewer:  ahf, gk        |        Sponsor:
---------------------------+-----------------------------------
Changes (by juga):

 * status:  assigned => needs_review
 * reviewer:   => ahf, gk


Comment:

 I've created #33691 to make reviews or migrate to gitlab.tpo, in the
 meanwhile i've pushed to GH: https://github.com/torproject/sbws/pull/372.

 See last commit documentation for some explanation about all changes.

 I think all these KeyValues were incorrect:

 In the header:

 - recent_consensus_count
 - recent_measurement_attempt_count
 - recent_priority_list_count
 - recent_priority_relay_count

 In the bandwidth lines:

 - relay_in_recent_consensus_count
 - relay_recent_measurement_attempt_count
 - relay_recent_priority_list_count

 I have not created different tickets for each of them since some of the
 changes touch the same parts of the code, there would be merge conflicts.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30905#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online