[tor-bugs] #33681 [Core Tor/Tor]: Refactor using_default_dir_authorities() local address checks

[Tor Bug Tracker & Wiki]

#33681: Refactor using_default_dir_authorities() local address checks
--------------------------------+--------------------------------
     Reporter:  teor            |      Owner:  teor
         Type:  task            |     Status:  assigned
     Priority:  Medium          |  Milestone:  Tor: 0.4.4.x-final
    Component:  Core Tor/Tor    |    Version:
     Severity:  Normal          |   Keywords:  prop312, ipv6
Actual Points:                  |  Parent ID:  #33236
       Points:  0.5             |   Reviewer:
      Sponsor:  Sponsor55-must  |
--------------------------------+--------------------------------
 Currently, we check for IPv4 and IPv6 local addresses and
 using_default_dir_authorities() in two different places:
 * IPv4: resolve_my_address()
 * IPv6: router_get_advertised_ipv6_or_ap()

 Once we've combined the code that checks IPv4 and IPv6 advertised ORPorts,
 we can do a single using_default_dir_authorities() check.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33681>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online