[tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  teor
     Type:  task            |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:  0.4
Parent ID:                  |         Points:  0.5
 Reviewer:  nickm           |        Sponsor:
----------------------------+------------------------------------
Changes (by teor):

 * keywords:  043-must, technical-debt => technical-debt
 * milestone:  Tor: 0.4.3.x-final => Tor: 0.4.4.x-final
 * actualpoints:  0.3 => 0.4


Comment:

 Replying to [comment:4 nickm]:
 > Actually, it looks like there is a non-spurious CI warning on the master
 version:
 > {{{
 > ./src/feature/relay/routerkeys.h:92:36: error: parameter ‘sign_out’ set
 but not used [-Werror=unused-but-set-parameter]
 >                                int *sign_out)
 >                                     ^~~~~~~~
 > ./src/feature/relay/routerkeys.h: In function
 ‘make_tap_onion_key_crosscert’:
 > ./src/feature/relay/routerkeys.h:106:35: error: parameter ‘len_out’ set
 but not used [-Werror=unused-but-set-parameter]
 >                               int *len_out)
 >                                    ^~~~~~~
 > }}}
 >
 > (The 0.4.3 branch is already merged)

 The master CI is running because I pushed a fix for that issue :-)

 Unfortunately, it doesn't show up on my local compiler, so it's been hard
 to make sure I caught all the bugs.

 Once CI passes, anyone can merge:
 * master: https://github.com/torproject/tor/pull/1822

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33674#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online