[tor-bugs] #33157 [Circumvention/Snowflake]: Client generates SDP with "IN IP4 0.0.0.0", causing proxy to send "client_ip=0.0.0.0" and bridge to send "USERADDR 0.0.0.0:1"

[Tor Bug Tracker & Wiki]

#33157: Client generates SDP with "IN IP4 0.0.0.0", causing proxy to send
"client_ip=0.0.0.0" and bridge to send "USERADDR 0.0.0.0:1"
-------------------------------------+------------------------------
 Reporter:  dcf                      |          Owner:  (none)
     Type:  defect                   |         Status:  needs_review
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------------

Comment (by arlolra):

 > It's okay with me but I would call the option --unsafe-logging instead
 of --unsafeLogging to match the style of the other options.

 In `broker/broker.go`, yes, dashes are used (ex. `disable-tls`, `acme-
 email`, etc), however, in `client/snowflake.go` we have camel casing (ex.
 `logToStateDir`, `keepLocalAddresses`, etc)

 We should probably consolidate this now.  I imagine your preference is for
 the former?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33157#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online