[tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  MrSquanchee
     Type:  enhancement                    |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.4.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052                         |         Points:  1
 Reviewer:                                 |        Sponsor:  Sponsor55-can
-------------------------------------------+-------------------------------
Changes (by teor):

 * status:  assigned => needs_revision


Comment:

 Hi, it's a bit hard to read and review this branch.

 So I made a pull request here:
 https://github.com/torproject/tor/pull/1808

 Please submit code for review as a pull request, even if it isn't ready
 yet.

 I made some specific comments on the pull request. Here are some general
 comments:
 * this code looks good, but how do you know it works?
 * there's no need to fix formatting issues on your own new code in a
 separate commit. Instead, run "make check" before you commit your code.
 And then you can fix issues before you commit.
 * you made a new file, so you'll need to add it to:
   * the sandbox:
     *
 https://github.com/torproject/tor/blob/master/src/app/main/main.c#L1032
     *
 https://github.com/torproject/tor/blob/master/src/app/main/main.c#L1055
   * the man page:
 https://github.com/torproject/tor/blob/master/doc/tor.1.txt#L3773
 * CI hasn't finished yet, so I don't know if your code compiles

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33617#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online