[tor-bugs] #28005 [Applications/Tor Browser]: Officially support onions in HTTPS-Everywhere

[Tor Bug Tracker & Wiki]

#28005: Officially support onions in HTTPS-Everywhere
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, https-everywhere, network-   |  Actual Points:  17
  team-roadmap-november, network-team-roadmap-   |
  2020Q1, TorBrowserTeam202003R, ux-team         |
Parent ID:  #30029                               |         Points:  20
 Reviewer:  mcs, sysrqb, antonela                |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------

Comment (by acat):

 Sorry, I forgot to mention that I also moved the
 `browser/components/onionalias` to `browser/components/onionservices`,
 following your comment in
 https://trac.torproject.org/projects/tor/ticket/21952#comment:111, which I
 assumed would also apply here. I also changed the update channel to use
 the testing securedrop one, instead of mine.

 Besides, one comment I had not answered:

 > The .tor.onion illusion is not complete. For example, I noticed that
 when I created a bookmark the unfriendly .onion name was stored in the
 bookmark. It might be difficult to find and fix all cases like this
 though. In the long run, I wonder if we can learn something from how
 things like AltSvc are implemented (I assume AltSvc is handled at a much
 lower level than the URL bar but I have not looked closely).

 I had thought about this one, I was not completely sure if this was the
 desired behaviour, but it probably is. Something we might want to
 consider: is there a reason for someone to want to bookmark explicitly the
 `.onion` and not the `.tor.onion`? If we later implement the urlbar
 rewrites when user types the .onion directly, it might be difficult for a
 user to do this (although technically still possible, by editing the
 bookmark manually via Bookmarks menu). Perhaps we can discuss this (in the
 next S27 meeting?), and I can revise the patch if it's decided it has to
 be done.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28005#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online