[tor-bugs] #19251 [Applications/Tor Browser]: TorBrowser might want to have an error page specific to when .onion links fail

[Tor Bug Tracker & Wiki]

#19251: TorBrowser might want to have an error page specific to when .onion links
fail
--------------------------------------------+------------------------------
 Reporter:  cypherpunks                     |          Owner:  brade
     Type:  enhancement                     |         Status:  needs_review
 Priority:  Low                             |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ux-team, TorBrowserTeam202003R  |  Actual Points:  6.7
Parent ID:  #30025                          |         Points:  6
 Reviewer:  acat,pospeselr                  |        Sponsor:
                                            |  Sponsor27-must
--------------------------------------------+------------------------------

Comment (by mcs):

 Replying to [comment:40 acat]:
 > The patches look good to me. Just a couple of nits for
 `onionNetError.jsm`:
 >
 > * Shouldn't `this._insertStylesheet` be after the `errPrefix` check? (so
 that the stylesheet is not added for non-onion errors).

 Good catch. We will move it and post a revised patch once we receive
 review comments from Richard.

 > * Can't we just do `ld.textContent = longDescription.replace("%S",
 hexErr);` instead of using `innerHTML` (and remove the eslint-disable), or
 `longDescription` may contain HTML?

 Mozilla sometimes uses HTML in the long description; we essentially copied
 this code:
 https://gitweb.torproject.org/tor-
 browser.git/tree/browser/base/content/aboutNetError.js?h=tor-
 browser-68.6.0esr-9.5-1#n233

 Since we are not currently using any markup in that field we could use the
 `textContent` property. Or we could keep it as we wrote it and match
 Mozilla. What do other people think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19251#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online