[tor-bugs] #33605 [Core Tor/Fallback Scripts]: Catch common bash runtime errors in fallback scripts

[Tor Bug Tracker & Wiki]

#33605: Catch common bash runtime errors in fallback scripts
-------------------------------------------+--------------------
     Reporter:  teor                       |      Owner:  (none)
         Type:  defect                     |     Status:  new
     Priority:  Medium                     |  Milestone:
    Component:  Core Tor/Fallback Scripts  |    Version:
     Severity:  Normal                     |   Keywords:
Actual Points:                             |  Parent ID:
       Points:  0.5                        |   Reviewer:
      Sponsor:                             |
-------------------------------------------+--------------------
 Let's gradually convert our scripts to use:
 {{{
 set -e
 set -u
 set -o pipefail
 }}}

 And maybe:
 {{{
 IFS=$'\n\t'
 }}}

 These settings help catch common errors in bash scripts at runtime:
 http://redsymbol.net/articles/unofficial-bash-strict-mode/

 (Shellcheck helps us catch errors while writing scripts, but it can't help
 with runtime failures.)

 Follow-up to #33451.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33605>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online