[tor-bugs] #33583 [Core Tor/Chutney]: Stop setting AssumeReachable on chutney relays and bridges

[Tor Bug Tracker & Wiki]

#33583: Stop setting AssumeReachable on chutney relays and bridges
------------------------------+--------------------------------
 Reporter:  teor              |          Owner:  teor
     Type:  enhancement       |         Status:  needs_review
 Priority:  Medium            |      Milestone:
Component:  Core Tor/Chutney  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:  ipv6, prop311     |  Actual Points:  0.2
Parent ID:  #33232            |         Points:  0.5
 Reviewer:  ahf               |        Sponsor:  Sponsor55-must
------------------------------+--------------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => ahf
 * actualpoints:   => 0.2


Comment:

 This is a very small PR on top of #33379.

 It moves `AssumeReachable 1` from common.i (all nodes) to authority.i
 (authorities, including the bridge authority). We don't want authorities
 to check relay or bridge reachability, because tor's 30 minute schedule is
 too slow.

 Everything else just works, because relay reachability self-checks succeed
 after any inbound connection:
 https://gitweb.torproject.org/torspec.git/tree/proposals/311-relay-
 ipv6-reachability.txt#n498

 It's good that authority reachability checks are turned off, because
 authorities would generate more (spurious) inbound connections.

 See my PR:
 * chutney: https://github.com/torproject/chutney/pull/58

 I'm guessing ahf will want to review this one, because it's based on
 #33379.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33583#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online