[tor-bugs] #33491 [Core Tor/Tor]: tor_bug_occurred_: Bug: src/core/or/dos.c:697: dos_new_client_conn: Non-fatal assertion !(entry == NULL) failed. (Future instances of this warning will be silenced.) (on Tor 0.4.2.6 )

[Tor Bug Tracker & Wiki]

#33491: tor_bug_occurred_: Bug: src/core/or/dos.c:697: dos_new_client_conn: Non-
fatal assertion !(entry == NULL) failed. (Future instances of this warning
will be silenced.) (on Tor 0.4.2.6 )
-----------------------------------------------+---------------------------
 Reporter:  sjcjonker                          |          Owner:  dgoulet
     Type:  defect                             |         Status:
                                               |  needs_information
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.4.4.x-final
Component:  Core Tor/Tor                       |        Version:  0.4.2.6
 Severity:  Normal                             |     Resolution:
 Keywords:  FreeBSD 043-backport 042-backport  |  Actual Points:
Parent ID:                                     |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by dgoulet):

 * status:  accepted => needs_information


Comment:

 Replying to [comment:3 sjcjonker]:
 > Checking matters further it seems the trigger happens when the
 connection comes from / via obfs4proxy.

 So hmmm... I think it has to do that your relay is a bridge and the code
 records the client with a `transport_name` but the DoS subsystem doesn't
 do that, it uses NULL every time and so it doesn't find the entry.

 What I wonder here is why all the sudden we are seeing this obvious bug...
 I run an obs4 bridge and I just check, never seen that `BUG()` :S ...

 What is the obs4 version you are using?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33491#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online