[tor-bugs] #30726 [Core Tor/Tor]: Missing relay keys in bandwidth file spec

[Tor Bug Tracker & Wiki]

#30726: Missing relay keys in bandwidth file spec
-------------------------------------+-----------------------------------
 Reporter:  teor                     |          Owner:  (none)
     Type:  defect                   |         Status:  needs_review
 Priority:  High                     |      Milestone:  sbws: 1.1.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Major                    |     Resolution:
 Keywords:  sbws-spec, sbws-roadmap  |  Actual Points:
Parent ID:  #33121                   |         Points:  6
 Reviewer:  ahf, gk                  |        Sponsor:
-------------------------------------+-----------------------------------
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:10 gk]:

 > > So i should check the collector to be sure about the which keys were
 in which versions
 >
 > Sounds good.

 I checked and all the collected bandwidth files started with the
 specification version 1.4.0, so in versions earlier than that it does not
 really matter the KeyValues are not correct.

 Still, i fixed them in their respective versions, including the version
 1.3.0 that was never generated by sbws (it should have been other ticket,
 but the change is small).

 https://github.com/torproject/torspec/pull/110

 What i should still check is whether we need to open tickets to metrics
 and stem because of the change of version in the spec. I don't think so
 because there were no bandwidth files published earlier than 1.4.0.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30726#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online