[tor-bugs] #30992 [Core Tor/Tor]: circpadding machines have shutdown sync issues (with intro circ NACKs and other cases)

[Tor Bug Tracker & Wiki]

#30992: circpadding machines have shutdown sync issues (with intro circ NACKs and
other cases)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad circpad-researchers-maybe-   |  Actual Points:
  want 043-should                                |
Parent ID:                                       |         Points:  3
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  assigned => needs_revision


Comment:

 Hello, I tested the branch on chutney and verified that it doesn't emit
 any `padding from wrong hop` or any #32044-style restarts. I then tested
 without the branch and verified both behaviors.

 I left some code-related comments on the branch. Can you fix those, and
 then open a PR so that we have CI running on this too?

 I can merge after this is done.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30992#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online