[tor-bugs] #32921 [Core Tor/Tor]: Code and script changes to run clang-format without breaking checkSpaces or coccinelle
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Jan 31 14:02:28 UTC 2020
#32921: Code and script changes to run clang-format without breaking checkSpaces or
coccinelle
----------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: style, 043-can | Actual Points: 1.5
Parent ID: #29226 | Points:
Reviewer: catalyst | Sponsor:
----------------------------+------------------------------------
Comment (by nickm):
> Comments on the `.clang-format` file:
Thank you! I am not attached to IndentCaseLabels or SpaceAfterLogicalNot,
though I think others may feel more strongly, and we should probably do a
quick straw poll.
I can probably hack something together with `codetool.py` to replace the
output of AlignEscapedNewlines with something closer to what emacs does;
do you think that would be worthwhile?
I would like to keep `KeepEmptyLinesAtTheStartOfBlocks: false` if we can.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32921#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list