[tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, 029-proposed, tor-control,     |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,       |
  034-triage-20180328, 034-removed-20180328      |
  043-can                                        |
Parent ID:                                       |         Points:  .1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 The implementation of routerstatus_has_changed() is correct, it's only
 designed to detect changes in the control port routerstatus format. Let's
 rename routerstatus_has_changed() to a name that contains "control"?

 If you'd like to remove the named and unnamed code, let's do it in another
 ticket, and try to remove as much as we can.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20218#comment:49>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online