[tor-bugs] #32960 [Core Tor/Tor]: CID 1457825: stub version of nt_service_parse_options() makes coverity think we have dead code

[Tor Bug Tracker & Wiki]

#32960: CID 1457825: stub version of nt_service_parse_options() makes coverity
think we have dead code
------------------------------+--------------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  easy regression 043-must
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------------
 {{{
  *** CID 1457825:  Possible Control flow issues  (DEADCODE)
 /src/app/main/main.c: 1244 in tor_run_main()
 1238         memcpy(argv + tor_cfg->argc, tor_cfg->argv_owned,
 1239                tor_cfg->argc_owned*sizeof(char*));
 1240
 1241       int done = 0;
 1242       result = nt_service_parse_options(argc, argv, &done);
 1243       if (done)
 >>>     CID 1457825:  Possible Control flow issues  (DEADCODE)
 >>>     Execution cannot reach this statement: "goto done;".
 1244         goto done;
 1245
 1246       pubsub_install();
 1247
 1248       {
 1249         int init_rv = tor_init(argc, argv);
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32960>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online