[tor-bugs] #32695 [Core Tor/Tor]: Remove consensus methods 25-27

[Tor Bug Tracker & Wiki]

#32695: Remove consensus methods 25-27
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  043-should, teor-backlog network-    |  Actual Points:  .1
  team-roadmap-2020Q1                            |
Parent ID:                                       |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Looks good as-is, except for one typo.

 If you'd like, we could also remove more code:
 * remove the `consensus_method` argument to `routerstatus_format_entry()`
 * delete `ROUTERSTATUS_FORMAT_NO_CONSENSUS_METHOD`
 * delete `node_awaiting_ipv6()`, because it is  false for all supported
 consensus methods
   * it was only ever true when microdescriptors had IPv6 addresses, and we
 were missing a microdescriptor for the node
 * delete `networkstatus_consensus_has_ipv6()`, because it's only used in
 `node_awaiting_ipv6()`
 * delete the unit tests for `networkstatus_consensus_has_ipv6()`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32695#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online