[tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs scaling onionbalance tor-     |  Actual Points:
  spec network-team-roadmap-2020Q1               |
Parent ID:  #26768                               |         Points:  2
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Hey hey,

 this looks really good. I actually tested this (and after fixing a few
 issues) I managed to connect to the backend service and exchange data over
 an onionbalance descriptor! That's a first!

 I pointed a few issues on GH. The main ones is an off-topic assertion
 failure on the logging subsystem, and the more important one is something
 weird going on with the `hs_cell_parse_introduce2 data` structure and
 `client_pk` gets wiped when it shouldn't. I fixed both of those issues
 quickly for testing but we need to fix them well.

 Other than that, it looks good, plus it needs changes file and man page
 entry. Also, a unittest for the config parsing wouldn't be bad if
 possible.

 Thanks a lot!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32709#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online