[tor-bugs] #32645 [Applications/Tor Browser]: Update URL bar onion indicators
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Feb 25 16:17:29 UTC 2020
#32645: Update URL bar onion indicators
--------------------------------------------+------------------------------
Reporter: antonela | Owner: pospeselr
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ux-team, TorBrowserTeam202002R | Actual Points: 3
Parent ID: #30025 | Points:
Reviewer: mcs | Sponsor:
| Sponsor27-must
--------------------------------------------+------------------------------
Comment (by mcs):
Replying to [comment:18 pospeselr]:
> Sorry, had to update this. Had a typo in a refactor I missed (was
overwriting the entire _identityBox, rather than _identityBox.className).
Pushed over the old branch (still a fixup commit).
>
> tor-browser: https://gitweb.torproject.org/user/richard/tor-
browser.git/commit/?h=bug_32645_v2
r=brade,r=mcs
I guess we should have caught that error.
Also, life is easier for reviewers when you create a new branch rather
than force-pushing over an older one ;)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32645#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list