[tor-bugs] #30196 [Core Tor/sbws]: Add the tor version to the sbws bandwidth file header
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Feb 24 15:15:25 UTC 2020
#30196: Add the tor version to the sbws bandwidth file header
---------------------------+-----------------------------------
Reporter: teor | Owner: (none)
Type: enhancement | Status: needs_review
Priority: High | Milestone: sbws: 1.2.x-final
Component: Core Tor/sbws | Version:
Severity: Major | Resolution:
Keywords: sbws-roadmap | Actual Points:
Parent ID: #33121 | Points: 1
Reviewer: ahf | Sponsor:
---------------------------+-----------------------------------
Changes (by juga):
* status: merge_ready => needs_review
Comment:
teor, i saw you did a review on my PR. I'm a bit confused cause you didn't
change this ticket as needs revision nor add you as reviewer. I've made
all (except 1) of the changes you suggested, plus others i realized about.
That's why i'm changing now this ticket to needs review again.
Note that i'm not squashing and force pushing, so the changes can be seen.
By experiences with other reviews that get a long list of fixups,
conflicts with rebases increase or individual commits can start getting
more confuse for myself.
Before a final merge (note for myself more than reviewer), the commit that
is actually about the tor version, should be reordered to be the last one.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30196#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list