[tor-bugs] #33385 [Circumvention/Snowflake]: In server, treat a purported client IP address of 0.0.0.0 as missing

[Tor Bug Tracker & Wiki]

#33385: In server, treat a purported client IP address of 0.0.0.0 as missing
-------------------------------------+------------------------
 Reporter:  dcf                      |          Owner:  dcf
     Type:  enhancement              |         Status:  closed
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:  fixed
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------
Changes (by dcf):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged in [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=c124e8c643f2de5730af9079d326b9cabc3b264a
 c124e8c643f2de5730af9079d326b9cabc3b264a].

 I also merged it into the turbotunnel branch at
 [https://gitweb.torproject.org/user/dcf/snowflake.git/commit/?h=turbotunnel&id=924593615c5a8fca7e0d9b4c0fafbd143db1bb62
 924593615c5a8fca7e0d9b4c0fafbd143db1bb62], because that branch is what's
 currently deployed (#33336) and I want to add an entry to MetricsTimeline
 marking when this `client_ip` change took effect. I'm afraid that if I
 only make the change in a branch that's not currently deployed, we will
 forget to mark the date when we do eventually move back to that branch. I
 built commit
 [https://gitweb.torproject.org/user/dcf/snowflake.git/log/?h=turbotunnel&id=47312dd1eccc8456652853bd66f8ed396e9ba6ec
 47312dd1eccc8456652853bd66f8ed396e9ba6ec] and deployed it at 2020-02-22
 23:51:15.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33385#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online