[tor-bugs] #33191 [Applications/GetTor]: Write database tests for twisted adbapi for GetTor
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Feb 19 19:52:24 UTC 2020
#33191: Write database tests for twisted adbapi for GetTor
---------------------------------+------------------------------
Reporter: cohosh | Owner: cohosh
Type: task | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/GetTor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points: .5
Reviewer: hiro | Sponsor:
---------------------------------+------------------------------
Description changed by cohosh:
Old description:
> Right now we're using the twisted database api for connecting to our
> sqlite3 database. This is difficult to use and test. BridgeDB uses the
> sqlite3 python package and that works just fine, perhaps we can move to
> that.
New description:
We discussed moving to a different sqlite3 api, but after talking with
@meejah, it's a bad idea to mix and match twisted with other I/O
operations.
So, we're opting to stay with twisted, write some tests that work, and see
whether we need to make changes to how dbpool is called and used.
--
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33191#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list