[tor-bugs] #33361 [Core Tor/Tor]: relay: Warn about the lack of ContactInfo and the consequence

[Tor Bug Tracker & Wiki]

#33361: relay: Warn about the lack of ContactInfo and the consequence
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-backport, 041-backport,          |  Actual Points:
  042-backport, 043-backport, network-health     |
Parent ID:                                       |         Points:  0.1
 Reviewer:  gk                                   |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:2 dgoulet]:
 > 035:
 >
 >  PR: https://github.com/torproject/tor/pull/1748
 >  Branch: `ticket33361_035_01`
 >
 > 043+:
 >
 >  PR: https://github.com/torproject/tor/pull/1749
 >  Branch: `ticket33361_043_01`

 I hope review comments here are fine (I don't have a Github account). So,
 generally this looks good to me.

 One thing I am not sure is whether this is actually a bugfix in tor's
 context or more a small feature. You know that better than me as I am not
 as well-versed regarding the network-team policies as you, so I am fine
 with whatever you pick, but I thought I'd mention it anyway.

 Some nits (the first two at least are for the `needs_revision`)

 1) Let's keep the comma after "setting it"

 2) s/your servers is/your server is/

 3) Just adding "end-of-life" here seems a bit vague. In the context of the
 changed warning message it seems we are concerned about their *server*
 getting end-of-life'd (whatever that means). Maybe operators start to
 think about their operating system when reading the message? I am not sure
 whether we want to cover that, though. Rather, I guess we are concerned
 about the Tor version getting EOL, right? If so, what about s/end-of-
 life/your Tor version reaches end-of-life/?

 4) Adding the enf-of-life part raises the question about Oxford comma or
 not. I am not sure either what the stance in the network-team here is. But
 if it's the case that the policy is "Yes, Oxford comma" then please do s
 /end-of-life or something/end-of-life, or something/.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33361#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online