[tor-bugs] #33366 [Core Tor/Tor]: Disable dns.c when relay mode is disabled
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Feb 18 23:04:51 UTC 2020
#33366: Disable dns.c when relay mode is disabled
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-design, network-team-roadmap- | Actual Points: .2
2020Q1, 043-deferred library-size |
Parent ID: #31851 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: merge_ready => needs_revision
Comment:
The following functions don't have stub implementations:
* dns_free_all
* assert_all_pending_dns_resolves_ok
* dns_cancel_pending_resolve
* dns_launch_correctness_checks
* dns_seems_to_be_broken_for_ipv6
Do they belong in the implementation file, rather than the header?
Or can they have a header comment, explaining why there's no stub?
In particular, it seems odd that `dns_seems_to_be_broken` has a stub, but
`dns_seems_to_be_broken_for_ipv6` does not.
(Feel free to merge_ready or merge once these minor issues are fixed.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33366#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list