[tor-bugs] #33368 [Core Tor/Tor]: Don't compile ext_orport.c when relay mode is disabled.
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Feb 18 22:54:47 UTC 2020
#33368: Don't compile ext_orport.c when relay mode is disabled.
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-design, network-team-roadmap- | Actual Points: .1
2020Q1, 043-deferred library-size |
Parent ID: #31851 | Points:
Reviewer: ahf | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: merge_ready => needs_revision
Comment:
Looks like `src/feature/client/transports.c` has some relay code. I added
it to the end of phase 2 in:
https://trac.torproject.org/projects/tor/ticket/31851#comment:10
The following functions don't have stub implementations:
* connection_or_get_by_ext_or_id
* init_ext_or_cookie_authentication
* ext_orport_free_all
Do they belong in the implementation file, rather than the header?
Or can they have a header comment, explaining why there's no stub?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33368#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list