[tor-bugs] #33374 [Core Tor/Tor]: Fix unocide warnings in practracker using python 2

[Tor Bug Tracker & Wiki]

#33374: Fix unocide warnings in practracker using python 2
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  teor
         Type:  defect   |     Status:  assigned
     Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
    Component:  Core     |    Version:  Tor: 0.4.3.1-alpha
  Tor/Tor                |   Keywords:  043-backport, consider-backport-
     Severity:  Normal   |  immediately
Actual Points:  0.1      |  Parent ID:
       Points:  0.1      |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 When I run practracker using python 2, I get the following unicode
 warning:
 {{{
 $ scripts/maint/practracker/practracker.py --regen-overbroad
 Traceback (most recent call last):
   File "scripts/maint/practracker/practracker.py", line 324, in <module>
     main(sys.argv)
   File "scripts/maint/practracker/practracker.py", line 268, in main
     for item in filt.filter(consider_all_metrics(files_list)):
   File "/Users/hyper/dev/tor/scripts/maint/practracker/problem.py", line
 147, in filter
     for item in iter(sequence):
   File "scripts/maint/practracker/practracker.py", line 110, in
 consider_all_metrics
     for item in consider_metrics_for_file(fname, f):
   File "scripts/maint/practracker/practracker.py", line 134, in
 consider_metrics_for_file
     for item in consider_function_size(fname, f):
   File "scripts/maint/practracker/practracker.py", line 91, in
 consider_function_size
     for name, lines in metrics.get_function_lines(f):
   File "/Users/hyper/dev/tor/scripts/maint/practracker/metrics.py", line
 58, in get_function_lines
     if line.startswith("}"):
 UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 22:
 ordinal not in range(128)
 Exit 1
 }}}

 We can fix this issue by using the codecs module to open files in unicode
 mode.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33374>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online