[tor-bugs] #32121 [Core Tor/Tor]: Refactor some common configs and functions out of the git scripts.

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Feb 16 07:30:32 UTC 2020


#32121: Refactor some common configs and functions out of the git scripts.
-------------------------------------+------------------------------------
 Reporter:  teor                     |          Owner:  nickm
     Type:  enhancement              |         Status:  needs_review
 Priority:  Medium                   |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  git-scripts, 044-should  |  Actual Points:  .5
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:10 dgoulet]:
 > This is a really great change! And dynamic so we in theory don't have to
 change anything for each release. +1

 We still have to update the list of branches in git-list-tor-branches.sh

 But that's much better than changing different branch references in every
 script.

 I also had some more ideas for testing:

 We can test the pre-commit and parts of the pre-push script by making a
 scripted commit in the test repository, then pushing it to the repository
 that Travis automatically checks out. (Using a file path, so we know it
 will stay local.)

 We can't test the upstream pre-push or the post-merge script, but that's
 ok.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32121#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list