[tor-bugs] #33087 [Core Tor/Tor]: closing stdio fds on exit can interfere with LeakSanitizer, etc

[Tor Bug Tracker & Wiki]

#33087: closing stdio fds on exit can interfere with LeakSanitizer, etc
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.1.6
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-log, 043-should, consider-       |  Actual Points:
  backport-after-0433, 041-backport,             |
  042-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  new => needs_review
 * version:   => Tor: 0.4.1.6


Comment:

 fsync() is required to be async signal safe by POSIX, see:
 http://manpages.ubuntu.com/manpages/bionic/man7/signal-safety.7.html

 See my PRs:
 * 0.4.1: https://github.com/torproject/tor/pull/1722
 * 0.4.3: https://github.com/torproject/tor/pull/1723
   * trivial merge of two function renames
 * master: https://github.com/torproject/tor/pull/1724
   * extra commit to remove a redundant array of log fds

 All the test branches are here:
 * https://github.com/teor2345/tor/branches/all?query=33087

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33087#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online