[tor-bugs] #30946 [Circumvention/BridgeDB]: Port BridgeDB to Python 3
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Feb 11 21:08:20 UTC 2020
#30946: Port BridgeDB to Python 3
------------------------------------+--------------------------
Reporter: phw | Owner: phw
Type: defect | Status: assigned
Priority: Medium | Milestone:
Component: Circumvention/BridgeDB | Version:
Severity: Normal | Resolution:
Keywords: python | Actual Points:
Parent ID: | Points: 10
Reviewer: | Sponsor:
------------------------------------+--------------------------
Changes (by phw):
* owner: (none) => phw
* status: needs_review => assigned
Comment:
Replying to [comment:7 atagar]:
> Hi Philipp. I skimmed over your branch (commit range fbc93cd..1c0281d)
and it looks good to me. As you mentioned the vast majority is
bytes/unicode normalization, and those look fine to me.
[[br]]
Great, thanks for taking a look!
[[br]]
> Minor thing but the shebangs are inconsistent...
>
> {{{
> % git diff fbc93cd..1c0281d | grep '+#!'
> +#!/usr/bin/env python3.7
> +#!/usr/bin/env python3
> }}}
[[br]]
Oops, that's a good catch. I pushed a fix.
Regarding next steps: I will run BridgeDB locally, to see if I encounter
any more runtime issues. Once this is looking good, I'll test-deploy it on
polyanthum, to see what runtime issues remain.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30946#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list