[tor-bugs] #19757 [Applications/Tor Browser]: Make a menu to add onion and auth-cookie to TB

[Tor Bug Tracker & Wiki]

#19757: Make a menu to add onion and auth-cookie to TB
-------------------------------------------------+-------------------------
 Reporter:  mrphs                                |          Owner:  brade
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-usability, tor-hs,      |  Actual Points:  7.1
  TorBrowserTeam202002R                          |
Parent ID:  #30000                               |         Points:  8
 Reviewer:  pospeselr, acat                      |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------

Comment (by pospeselr):

 This looks good to me, but a few nits that don't really matter:

 https://gitweb.torproject.org/user/brade/tor-
 browser.git/tree/browser/components/onionservices/content/authPrompt.js?id=06f115cc028e27124b48b40aaa83e988c28a9d98#n165
 > 165         let checkboxElem = this._getCheckboxElement();
 > 166         let isPermanent = (checkboxElem && checkboxElem.checked);

 I'd move these down within the try block before the {{{onionAuthAdd}}}
 call as it doesn't seem like {{{isPermanent}}} is used anywhere else in
 the higher scope.

 https://gitweb.torproject.org/user/brade/tor-
 browser.git/tree/browser/components/onionservices/content/authPreferences.js?id=06f115cc028e27124b48b40aaa83e988c28a9d98#n19
 > 19      string: {
 > 20        groupBoxID: "torOnionServiceKeys",
 > 21        headerSelector: "#torOnionServiceKeys-header",
 > 22        overviewSelector: "#torOnionServiceKeys-overview",
 > 23        learnMoreSelector: "#torOnionServiceKeys-learnMore",
 > 24        savedKeysButtonSelector: "#torOnionServiceKeys-savedKeys",
 > 25      },

 I'd call {{{string}}} something like 'selectors' or something like that
 (here and also in authUtil.jsm, savedKeysDialog.js, etc)

 Apart from those nits it looks good!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19757#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online