[tor-bugs] #33192 [Core Tor/Tor]: Stop assuming that /usr/bin/python exists
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Feb 10 23:24:03 UTC 2020
#33192: Stop assuming that /usr/bin/python exists
----------------------------------+------------------------------------
Reporter: alwayslivid | Owner: (none)
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: extra-review 043-can | Actual Points:
Parent ID: #33193 | Points:
Reviewer: | Sponsor:
----------------------------------+------------------------------------
Comment (by teor):
Replying to [comment:9 alwayslivid]:
> Replying to [comment:6 teor]:
> > Replying to [comment:4 alwayslivid]:
> > > I could close the pull request and make the change again on top of
the master or another desired branch.
> >
> > That would be great!
>
> Just for the sake of clarification, I ought to use the master branch for
my own changes, right?
Yes please!
> > Replying to [comment:5 alwayslivid]:
> > > I checked some of the scripts and changed "python" to "python2"
wherever the syntax wouldn't allow using Python 3.
> >
> > We'd like to transition to Python 3, since python 2 is not supported.
So let's leave those scripts with "python" and fix the Python 3
>
> Transitioning from Python 2 to 3 would be pretty great, especially when
you take how critical Tor and its surrounding software is into account.
For the time being, however, this change would potentially break some of
the scripts, considering that `python` can also refer to `python3` and
some scripts simply aren't suited for `python3` right now. Maybe this
explicit mention of `python2` would also mobilize more people to work on
that. (I'd like to do some work on that myself later on.)
Some OSes don't install Python 2 as `python2`, so we can't change to
`/usr/bin/env python2` in the current tor 0.4.3 alpha series.
Maybe it would be best to leave all these changes until 0.4.4, when we
have time to fix any Python 3 issues?
> I'm not sure whether I misinterpreted something, but the changes of the
aforementioned tree (#33193) don't seem to be conflicting with my own
changes in any capacity.
I wasn't sure if there were conflicts.
But I thought if you were trying to fix issues with Python 3, you might
want to re-use some of those fixes.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33192#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list