[tor-bugs] #33093 [Core Tor/Tor]: Use IF_BUG_ONCE in buf_flush_to_tls()
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Feb 10 21:49:37 UTC 2020
#33093: Use IF_BUG_ONCE in buf_flush_to_tls()
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status:
| merge_ready
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: assert, tor-connection security-low | Actual Points: .1
consider-backport-after-0433 035-backport |
041-backport 042-backport |
Parent ID: | Points:
Reviewer: ahf | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
Replying to [comment:7 cypherpunks]:
> Replying to [ticket:33093 nickm]:
> > See parent: the BUG() messages in this function caused dgoulet to run
out of disk.
>
> Doesn't #32472 say the opposite happened? (Running out of disk space
caused the BUG().)
The bug report is a bit unclear. Some people learned English later in
life, or learned a different dialect of English. So they write sentences
in a different order.
But it's really unlikely that:
* a disk full error stops tor writing TLS to the network,
* then tor logs a lot of log lines,
* which end up being written to (a full) disk.
It's far more likely that a TLS error (or tor bug) has caused large
quantities of logs, and they filled up the disk.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33093#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list