[tor-bugs] #32230 [Core Tor/Tor]: configure summary is confusing or incorrect

[Tor Bug Tracker & Wiki]

#32230: configure summary is confusing or incorrect
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  dgoulet
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:  043-must      |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * cc: nickm (added)
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:1 dgoulet]:
 > Replying to [ticket:32230 teor]:
 > > Inverted, should be --enable-* :
 > > * --disable-seccomp
 > > * --disable-libscrypt
 > > * --disable-gcc-hardening ?
 > > * --disable-linker-hardening ?
 > > * --disable-module-dirauth
 > > * --disable-unittests
 >
 > All these are enabled by default and thus why we put in the `--disable`.
 If one does autocompletion on `./configure --enable-`, none of the above
 shows up.

 Ok, but the output is still wrong:

 {{{
 test "x$enable_seccomp" != "xno" && value=1 || value=0
 PPRINT_PROP_BOOL([libseccomp (--disable-seccomp)], $value)
 }}}

 If enable_seccomp is yes, then value is 1, and we print --disable-seccomp
 yes.
 But we should actually print one of these:
 * --enable-seccomp yes
 * --disable-seccomp no

 I prefer the output without the double-negative.
 But I can understand if you want to print the non-default option as well.

 > > * --with-tor-user=[user]
 > > * --with-tor-group=[group]
 >
 > I have no clue where this is used. I can't find `TORUSER` or `TORGROUP`
 being used anywhere?

 Maybe nickm can help?

 > > * and a few others
 > > * and a whole bunch of env vars
 >
 > For now this is a good improvement! We can add the rest as we notice
 them.

 Yes, I agree. A good summary doesn't need everything. Just the important
 and useful things.

 > Branch: `ticket32230_043_01`
 > PR: https://github.com/torproject/tor/pull/1701

 I'll do a full review once the PR has been revised.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32230#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online