[tor-bugs] #32088 [Core Tor/Tor]: Proposal 310 - choose guards in sampled order
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Apr 29 15:12:58 UTC 2020
#32088: Proposal 310 - choose guards in sampled order
--------------------------------------+------------------------------------
Reporter: Jaym | Owner: (none)
Type: enhancement | Status: needs_revision
Priority: High | Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-spec prop271 prop310 | Actual Points:
Parent ID: | Points:
Reviewer: nickm, asn | Sponsor:
--------------------------------------+------------------------------------
Changes (by asn):
* status: needs_review => needs_revision
* reviewer: nickm => nickm, asn
Comment:
Hello, thanks for all the work here! I actually missed the proposal and
the ticket so this caught me by surprise today. This seems really well
thought all-in-all and a solid patch, and the test adjustments look good
to.
I added a few comments to the PR. It's mainly documentation requests to
polish some parts that I didn't comprehend.
Also, can the next revision come with a new PR, which contains the changes
in the top commits? This can be done with a rebase. Isolating the changes
of this PR was not easy for me because the relevant commits were scattered
around the log.
Thanks a lot!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32088#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list