[tor-bugs] #34005 [Applications/Tor Browser]: ./mach configure --disable-compile-environment breaks for Tor Browser

[Tor Bug Tracker & Wiki]

#34005: ./mach configure --disable-compile-environment breaks for Tor Browser
------------------------------------------+--------------------------------
     Reporter:  gk                        |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
                                          |  ReleaseTrainMigration
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+--------------------------------
 Sometimes it is useful to use Mozilla's build environment without checking
 whether all the compilers and necessary tools are available (see for
 instance #33973). Mozilla has the `--disable-compile-environment` option
 for that. It succeeds with a clean Mozilla esr68 branch but fails for us
 for three reasons if we delete the respective `.mozconfig` file:

 1) `--disable-tor-launcher` needs to be set even though we don't want to
 compile anything
 2) `--with-tor-browser-version` needs to be specified even though we don't
 want to compile anything
 3) `--enable-official-branding` needs to be specified because otherwise
 `default512.png` in the unofficial branding is missing (or
 `default256.png` for the esr68-based branches)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34005>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online