[tor-bugs] #33993 [Applications/rbm]: In input_files, target, target_prepend, target_append are silently ignored if they are not an array

[Tor Bug Tracker & Wiki]

#33993: In input_files, target, target_prepend, target_append are silently ignored
if they are not an array
-----------------------------------+------------------------------
 Reporter:  boklm                  |          Owner:  boklm
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:
Component:  Applications/rbm       |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam202004R  |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------
Changes (by boklm):

 * status:  new => needs_review
 * keywords:   => TorBrowserTeam202004R


Comment:

 There is a patch for review in branch `bug_33993`:
 https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_33993&id=fa52f61d00ad95107e9f6e10cfe6317d42cb5771

 If I add this change:
 {{{
 diff --git a/test/projects/r3/config b/test/projects/r3/config
 index e3a97f1..ececbaf 100644
 --- a/test/projects/r3/config
 +++ b/test/projects/r3/config
 @@ -5,3 +5,4 @@ build: |
    echo 3 - [% c('pkg_type') %] >> [% dest_dir %]/[% c('filename') %]
  input_files:
    - project: r2
 +    target_append: aaaa
 }}}

 And then run `./test.pl`, it now fails with:
 {{{
 Error: target_append should be an ARRAY:
 { project => "r2", target_append => "aaaa" }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33993#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online