[tor-bugs] #33956 [Core Tor/Tor]: Define and use TOR_ADDRPORT_BUF_LEN

[Tor Bug Tracker & Wiki]

#33956: Define and use TOR_ADDRPORT_BUF_LEN
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:           |     Status:  new
  enhancement            |
     Priority:  Medium   |  Milestone:  Tor: unspecified
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  refactor, technical-debt, prop311,
     Severity:  Normal   |  prop312, prop313
Actual Points:           |  Parent ID:
       Points:  0.5      |   Reviewer:
      Sponsor:           |
  Sponsor55-can          |
-------------------------+-------------------------------------------------
 In #33918, we discovered a bug where IPv6 addresses were being truncated
 in logs.

 During the fix, we noticed that we had a TOR_ADDR_BUF_LEN, but no
 equivalent constant for addresses and ports. The new TOR_ADDRPORT_BUF_LEN
 should allow space for:
 * TOR_ADDR_BUF_LEN
 * IPv6 brackets (2, if not included in TOR_ADDR_BUF_LEN already)
 * the port separator (1)
 * the port (5)

 We should check for other truncation errors while making this change.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33956>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online