[tor-bugs] #33930 [Applications/Tor Browser]: Tor binary we build seems to not getting picked up in nightly builds (was: Tor binary we build is not picked up in nightly builds)

[Tor Bug Tracker & Wiki]

#33930: Tor binary we build seems to not getting picked up in nightly builds
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity,     |  Actual Points:
  TorBrowserTeam202004, GeorgKoppen202004        |
Parent ID:  #28704                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Old description:

> We build Tor for Android now ourselves thanks to the fix for #28766. But
> unfortunately it is not picked up yet, despite #32993 claiming so. I
> stumbled across this when testing a fix for #32027. The branch has all
> patches for #28704 and children but it's still shown that we use the Tor
> we've been bundling so far but not the one we compile.

New description:

 We build Tor for Android now ourselves thanks to the fix for #28766. But
 unfortunately it seems at least as it is not picked up yet, despite #32993
 claiming so. I stumbled across this when testing a fix for #32027. The
 branch has all patches for #28704 and children but it's still shown that
 we use the Tor we've been bundling so far but not the one we compile.

--

Comment (by gk):

 Okay, I have been looking closer. Looking at the `libTor.so` we actually
 ship in nightlies *does* imply that it contains the `tor` and `OpenSSL`
 version we compile (I ran `strings` over the `.so` file), so that's good.
 What is happening is that the binary version check done in `tor-android-
 service` is just returning a hard-coded string `TOR_VERSION`, which is
 currently set to `0.4.1.5-rc-openssl1.0.2p`.

 So, we might actually be good here at least with respect to the actually
 used Tor/OpenSSL version, but that's hard to say. Either way, we need to
 come up with a better solution than hard-coding given that we support
 different Tor versions in parallel now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33930#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online