[tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Apr 17 14:22:04 UTC 2020
#33557: Update Android Toolchain for Fenix
-------------------------------------------------+-------------------------
Reporter: sisbell | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, Android, | Actual Points:
TorBrowserTeam202004R |
Parent ID: #33184 | Points:
Reviewer: sysrqb | Sponsor:
| Sponsor58-must
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:9 sisbell]:
> Another issue I encountered is that android-components and fenix use
different version of the Android SDK, Fenix is on 28 and android-
components is on 29. I'll need to bring these into alignment (up to 29 for
fenix)
That does not seem so easy. Right now Fenix is broken with our toolchain.
It breaks during compilation like:
{{{
> Task :app:compileGeckoBetaDebugKotlin
e: /var/tmp/build/fenix-
943d3837b243/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt:
(81, 9): Val cannot be reassigned
e: /var/tmp/build/fenix-
943d3837b243/app/src/main/java/org/mozilla/fenix/library/history/HistoryController.kt:
(76, 9): Val cannot be reassigned
e: /var/tmp/build/fenix-
943d3837b243/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt:
(32, 13): Val cannot be reassigned
}}}
That does not happen if I use our current toolchain. I can compile Fenix
successfully with it.
I wonder if we should try harder to match what Mozilla is currently using
toolchain-wise. That is whether we should bite the bullet and use
different ones for Fenix and android-components...
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33557#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list