[tor-bugs] #33899 [Core Tor/Tor]: Allow IPv6 addresses to be canonical

[Tor Bug Tracker & Wiki]

#33899: Allow IPv6 addresses to be canonical
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  teor
         Type:  defect   |     Status:  assigned
     Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
    Component:  Core     |    Version:  Tor: 0.3.1.1-alpha
  Tor/Tor                |   Keywords:  ipv6, prop311, network-team-
     Severity:  Normal   |  roadmap-2020Q2
Actual Points:           |  Parent ID:  #33220
       Points:  0.5      |   Reviewer:
      Sponsor:           |
  Sponsor55-must         |
-------------------------+-------------------------------------------------
 In #17604, we allowed IPv6 connections to set is_canonical_to_peer. But we
 did not let them set is_canonical.

 So channel_tls_process_netinfo_cell() handles IPv6 addresses, but
 connection_or_check_canonicity() does not.

 This inconsistency could be one cause of the logging issues in #24841.

 We should allow IPv6 connections to be canonical. We should also do some
 cleanup of the related connection address logging in #33898.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33899>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online