[tor-bugs] #33745 [Circumvention/Snowflake]: Merge a turbotunnel branch

[Tor Bug Tracker & Wiki]

#33745: Merge a turbotunnel branch
-------------------------------------+--------------------------------
 Reporter:  dcf                      |          Owner:  dcf
     Type:  task                     |         Status:  needs_revision
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  turbotunnel              |  Actual Points:
Parent ID:  #19001                   |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+--------------------------------
Changes (by cohosh):

 * status:  needs_review => needs_revision


Comment:

 Okay, these changes look good to me. Some things I noticed while going
 through to code again:

 - there's something up with the go.sum file you generated that's causing
 security errors for me. Specifically the hash for `github.com/tjfoc/gmsm`
 seemed wrong. I fixed this by removing go.sum and then regenerating it.
 Can you take a look at your end and see if you're having the same issues?

 - for the changes in
 [https://gitweb.torproject.org/user/dcf/snowflake.git/commit/?h
 =turbotunnel-merge&id=43f540e23d49af6ea75389ddc8808fdb1d482d5e this
 commit], it looks like we can still end up with a blocking goroutine
 waiting to read from a KCP stream once the SOCKS connection closes.

  In fact, since the KCP stream is kept alive, will this stay open
 indefinitely (or until Tor Browser restarts/closes)?

 - this is a nitpick, but the comments and variable names in `Handler` and
 `copyLoop` still assume this is a WebRTC session and not a KCP stream
 [https://gitweb.torproject.org/user/dcf/snowflake.git/tree/client/lib/snowflake.go?h
 =turbotunnel-merge&id=619802d12707baf5aee7091a7f1c02c3dbcaa30c#n166 here].

 I'll put it in needs_revision to hear back about these points but I
 generally think it's good to go.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33745#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online