[tor-bugs] #33870 [- Select a component]: vanguards: Vanguards silently fail on certain condition

[Tor Bug Tracker & Wiki]

#33870: vanguards: Vanguards silently fail on certain condition
-------------------------+--------------------------------------
 Reporter:  cypherpunks  |          Owner:  (none)
     Type:  defect       |         Status:  new
 Priority:  Medium       |      Component:  - Select a component
  Version:               |       Severity:  Major
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+--------------------------------------
 1. Configure torrc file (add some HiddenService lines)

 2. Edit vanguards.conf like below:

 {{{
 # IP address that the Tor control port is listening on:
 control_ip =

 # TCP port the control port is listening on:
 control_port =

 # If set, use this filesystem control socket instead of IP+Port:
 control_socket = /run/tor/control

 # If set, use this as the control port password:
 control_pass =
 }}}

 {{{
 # The current loglevel:
 loglevel = NOTICE

 # If specified, log to this file instead of stdout:
 logfile = /tmp/vandebugger
 }}}

 3. Restart vanguards (service vanguards stop;service vanguards start)

 4. Run 'ps axu|grep pypy' - you'll find vanguards is running

 5. Now wait 1 minute

 ---

 What will happen:
 1. Vanguards silently exit itself. /tmp/vandebugger logged nothing.
 2. However if you read syslog you'll find this line:

 {{{
 Specified config file /meow/vanguards.conf can't be read: invalid literal
 for int() with base 10: ''
 }}}


 How to fix:
 Setting 'control_port = ' to 'control_port = 9876' fixed this.

 What do I want:
 Error should not be raised if the user set 'control_port' empty string.


 #NoGithub #ILikeYourAddon

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33870>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online