[tor-bugs] #33072 [Core Tor/Tor]: When under load, give 503 aggressively for dirport requests without compression

[Tor Bug Tracker & Wiki]

#33072: When under load, give 503 aggressively for dirport requests without
compression
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  network-health 044-should consider-  |  Actual Points:
  backport-after-0434 042-backport 043-backport  |
Parent ID:  #33018                               |         Points:
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 Replying to [comment:25 teor]:
 > It looks like the code, function comments, and changes files are out of
 sync in these branches.
 >
 > These lines are only deleted in maint-0.4.3:
 > {{{
 >   if (c_method != NO_METHOD) {
 >       /* Always answer compressed request. */
 >       return false;
 >     }
 > }}}
 >
 > Are there tests that give a different result when this code is deleted?
 > (I don't want to block on tests, so maybe we could do them later in
 master.)

 Wait...hmmm ok I will re-assess all 3 branches, this is getting confusing.
 Sorry about that.

 >
 > Also, I'm a bit confused about how you want me to merge here. There's no
 forward merges in these PRs. So when we backport, we'll need to do an
 "ours" merge forward, to avoid conflicts. Is that ok?

 Yeah... What about cherry-picking the commits and being done with it? I
 agree it is not good but the backport is surprisingly non trivial on each
 version :(

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33072#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online