[tor-bugs] #33812 [Core Tor/Tor]: Add unit tests for bandwidth statistics functions
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Apr 9 06:20:44 UTC 2020
#33812: Add unit tests for bandwidth statistics functions
-------------------------------------------+-------------------------------
Reporter: MrSquanchee | Owner: MrSquanchee
Type: task | Status: assigned
Priority: Medium | Milestone: Tor:
| unspecified
Component: Core Tor/Tor | Version:
Severity: Minor | Resolution:
Keywords: prop313, ipv6, outreachy-ipv6 | Actual Points:
Parent ID: #33617 | Points: 2
Reviewer: ahf | Sponsor: Sponsor55-can
-------------------------------------------+-------------------------------
Changes (by MrSquanchee):
* status: needs_information => assigned
Comment:
Replying to [comment:5 ahf]:
> I think these patches are definitely a step in the right direction. The
overall code seems sound.
Thanks. After everything is done, I need to make sure that these tests are
exhaustive.
> What is the next step here? It sounds you want to do additional work
here?
I need to add tests for rep_hist_fill_bandwidth_history and
rep_hist_get_bandwidth_lines().
And as [https://github.com/torproject/tor/pull/1853#discussion_r403786213
teor said] I have to refactor bandwidth code in a new file bw_array_st.h
and bw_array_st.c.
Thanks,
Suraj Upadhyay (!MrSquanchee).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33812#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list