[tor-bugs] #32683 [Metrics/Relay Search]: Relay Search should be able to handle non-numbers in "as:" parameter

[Tor Bug Tracker & Wiki]

#32683: Relay Search should be able to handle non-numbers in "as:" parameter
----------------------------------+------------------------------
 Reporter:  karsten               |          Owner:  metrics-team
     Type:  defect                |         Status:  closed
 Priority:  Medium                |      Milestone:
Component:  Metrics/Relay Search  |        Version:
 Severity:  Normal                |     Resolution:  fixed
 Keywords:                        |  Actual Points:  0.2
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * actualpoints:   => 0.2


Comment:

 Replying to [comment:3 irl]:
 > #8667 is related.

 Looks related, yes. When I worked on this ticket I focused on defects and
 didn't spot that other ticket. I'll leave a comment there.

 > Relay Search indeed doesn't do any validation of the query before
 sending it. We could return a JSON document along with 400 error codes, to
 allow Onionoo to provide a more detailed message back to the user, but
 better error messages help too.

 You mean that Onionoo could return such a JSON document to allow Relay
 Search to provide a more detailed message? I made a similar suggestion on
 #32065 shortly after commenting here. I think it's a good idea. Let's
 discuss that more on #32065.

 > It's a bit upsetting that the same error message is in multiple files, I
 should learn more about the template language and see if we can use
 includes.

 Agreed, not having to repeat ourselves would be nice. Not the end of the
 world in this case, though.

 Alright, merged and deployed. Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32683#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online