[tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--------------------------------------+------------------------------------
 Reporter:  teor                      |          Owner:  nickm
     Type:  enhancement               |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  1
Parent ID:                            |         Points:  2
 Reviewer:  teor                      |        Sponsor:
--------------------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 These changes look good, and distcheck now passes.

 But I'm still seeing a similar error in appveyor.

 I don't entirely understand the script. But I wonder if os.path.relpath()
 would work in normalize_srcdir(). It seems like the regular expressions
 depend on unix paths.

 See:
 https://docs.python.org/3/library/os.path.html#os.path.relpath

 That's how add_c_file.py does it:
 https://github.com/torproject/tor/blob/master/scripts/maint/add_c_file.py#L41

 I'm not sure if you'll need os.path.normpath() here, because it modifies
 the slashes in the string:
 https://docs.python.org/3/library/os.path.html#os.path.normpath

 I don't want to block this ticket, so I would also accept:
 * opening an 044-should ticket to fix this check on Windows
 * adding a comment to any Windows-only subsystems, reminding us to double-
 check their order

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31634#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online