[tor-bugs] #31652 [Core Tor/Tor]: hs-v3: Service circuit retry limit should not close a valid circuit

[Tor Bug Tracker & Wiki]

#31652: hs-v3: Service circuit retry limit should not close a valid circuit
---------------------------------------------+-----------------------------
 Reporter:  dgoulet                          |          Owner:  neel
     Type:  defect                           |         Status:
                                             |  needs_revision
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.4.2.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  tor-hs, tor-circuit, 042-should  |  Actual Points:
Parent ID:  #30200                           |         Points:  0.1
 Reviewer:  asn                              |        Sponsor:
                                             |  Sponsor27-must
---------------------------------------------+-----------------------------

Comment (by asn):

 Replying to [comment:19 neel]:
 > To clarify, is the bug you are talking about related to removing the
 intro point if `hs_circ_service_get_intro_circ()` is true? If not, what is
 it?

 Yep! Before `861ff757712d008424746e9d1e9bd85b3f472dee` we used to return
 `True` if `hs_circ_service_get_intro_circ(ip)` is true. After that commit,
 we return `False`.
 This seems like a behavior change and not just refactoring.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31652#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online